[Link new device] Rotate QrCode instead of showing an error#6817
Merged
Conversation
bmarty
added
PR-Wip
github-actions
Bot
removed
the
Record-Screenshots
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6817 +/- ##
========================================
Coverage 81.27% 81.27%
========================================
Files 2648 2651 +3
Lines 74169 74214 +45
Branches 9619 9622 +3
========================================
+ Hits 60281 60321 +40
- Misses 10341 10346 +5
Partials 3547 3547 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmartinesp
reviewed
May 19, 2026
bmarty
force-pushed
the
feature/bma/automaticRetry
branch
from
ff33676 to
900b888
Compare
jmartinesp
approved these changes
May 20, 2026
Member
jmartinesp
left a comment
jmartinesp
left a comment
There was a problem hiding this comment.
Thanks for the latest changes, it looks way cleaner now!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
When a QrCode is displayed, the user has about 1 minute to scan the QrCode. After the rendezvous session is closed and cannot be used anymore. To mitigate this, the application is now automatically rotating the QrCode 10 times, to give enough time for the user to scan the code. After 10 times, the existing error screen is shown, to avoid having infinite retry.
There is still a doubt on how the timeout is detected (I asked in the internal room), but the test are working fine here.
The application is showing a spinner instead of the QrCode only if the QrCode (re)generation is taking more than 1 second, to have a smooth transition between 2 consecutive QrCodes.
Motivation and context
Closes #6806
Screenshots / GIFs
Screen_recording_20260519_150935.mp4
Tests
It should be possible to scan any QrCode to link a new device
All back press should be correclty handled (for st QrCode and next ones).
Tested devices
Checklist